Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: autocomplete behavior #544

Merged
merged 2 commits into from
Jul 27, 2023
Merged

fix: autocomplete behavior #544

merged 2 commits into from
Jul 27, 2023

Conversation

f-necas
Copy link
Collaborator

@f-necas f-necas commented Jul 25, 2023

Update suggestions to match predefined buttons click

@f-necas f-necas requested a review from fgravin July 25, 2023 15:00
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023 •
edited
Loading

Affected libs: ui-inputs, feature-dataviz, feature-record, feature-router, feature-editor, feature-search, feature-map, ui-elements, feature-catalog, ui-catalog, ui-search,
Affected apps: metadata-converter, metadata-editor, datahub, demo, webcomponents, search, datafeeder, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Jul 25, 2023 •
edited
Loading

Coverage Status

coverage: 82.967% (+0.05%) from 82.915% when pulling cab7e52 on fix-search-buttons into 94252f4 on main.

fgravin
fgravin approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thanks !
Maybe adding a test for that would be good 😉

@fgravin fgravin added this to the 1.1.0 milestone Jul 27, 2023
@f-necas f-necas merged commit 044f11f into main Jul 27, 2023
5 checks passed
@f-necas f-necas deleted the fix-search-buttons branch July 28, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgravin fgravin fgravin approved these changes

Assignees

@f-necas f-necas

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@f-necas @coveralls @fgravin